fix: Http client exception not handled properly resulting in incorrectly formatted error #1021

2shrestha22 · 2024-11-27T17:08:15Z

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

Closes: #1022

Approach

Tasks

Add tests
Add changes to documentation (guides, repository pages, code comments)

Summary by CodeRabbit

Bug Fixes
- Enhanced error handling to provide more detailed responses when client connection exceptions occur.
Refactor
- Streamlined internal SDK structure and architecture for improved code organization and maintainability.

parse-github-assistant · 2024-11-27T17:08:20Z

Thanks for opening this pull request!

mbfakourii · 2024-11-28T14:11:17Z

packages/dart/lib/src/objects/response/parse_exception_response.dart

    ));
  }

+  if (exception is ClientException) {


We use two clients, dio and http, at Parse Flutter !

In this change you are using the functions of the http package. Will this not cause any problems when we use the dio package client?

DioException is already being handled above but ClientException was missing.

mbfakourii · 2024-11-28T14:14:15Z

@mtrezza

Can you please run CI?

mtrezza · 2024-11-30T17:38:32Z

@mbfakourii done

codecov · 2024-11-30T17:40:02Z

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.47%. Comparing base (c388545) to head (65f624e).
Report is 8 commits behind head on master.

Files with missing lines	Patch %	Lines
...src/objects/response/parse_exception_response.dart	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1021      +/-   ##
==========================================
+ Coverage   43.37%   43.47%   +0.10%     
==========================================
  Files          61       61              
  Lines        3463     3466       +3     
==========================================
+ Hits         1502     1507       +5     
+ Misses       1961     1959       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

parse-github-assistant · 2024-12-04T01:45:41Z

I will reformat the title to use the proper commit message syntax.

mtrezza · 2024-12-04T01:46:47Z

I rephrased the PR title; not sure whether it accurately describes the issue, could you please review?

2shrestha22 · 2024-12-04T01:54:02Z

I think it's better.

mtrezza · 2024-12-08T12:06:27Z

There is still an open review discussion and the changelog entry + version bump is missing in the PR. See other PRs on how they are done. Then we can go ahead and merge.

coderabbitai · 2025-11-15T03:00:22Z

📝 Walkthrough

Walkthrough

The changes consolidate the SDK's modularized structure and enhance exception handling. The main library file now imports the http package and removes part directives that previously split functionality across separate files. Additionally, ClientException from the http package is now explicitly handled in response exception processing, converting it to a ParseError.

Changes

Cohort / File(s)	Summary
Module restructuring `packages/dart/lib/parse_server_sdk.dart`	Added import for http package and removed all part directives, consolidating the previously modularized public API into a single file.
Exception handling `packages/dart/lib/src/objects/response/parse_exception_response.dart`	Added new branch in buildParseResponseWithException to handle ClientException, converting it to ParseResponse with ParseError containing the exception's message.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Verify that all previously separated module functionality remains accessible after consolidation and that no circular dependencies or import order issues are introduced
Confirm ClientException handling is properly sequenced in the exception chain and test with actual http package exception scenarios

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	The PR includes an out-of-scope change: removing part directives and collapsing the modularized public API in parse_server_sdk.dart is unrelated to handling ClientException and appears to be a refactoring outside the issue's scope.	Revert the changes to parse_server_sdk.dart that remove part directives, or create a separate PR for that refactoring. Keep this PR focused solely on ClientException handling in parse_exception_response.dart.
Description check	❓ Inconclusive	The PR description is incomplete. While it references issue #1022, the 'Approach' section lacks implementation details explaining how the fix was implemented.	Fill in the 'Approach' section with a detailed description of the changes made to handle ClientException, such as how the exception is now being caught and processed in the response handler.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: handling of HTTP ClientException that was previously not being handled properly, resulting in incorrectly formatted errors.
Linked Issues check	✅ Passed	The PR addresses the main objective from issue #1022 by adding ClientException handling in the response builder, converting unhandled exceptions into properly formatted ParseResponse errors.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

2shrestha22 · 2025-11-15T03:02:07Z

There is still an open review discussion and the changelog entry + version bump is missing in the PR. See other PRs on how they are done. Then we can go ahead and merge.

I thought changelog and version bump should be maintained on release instead of PR merge.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/dart/lib/parse_server_sdk.dart (1)
12-12: Narrow http import to avoid potential symbol clashes with dio

Given this is the root library for many part files and you already import package:dio/dio.dart, bringing in all of package:http/http.dart risks name clashes (e.g., Response) in any part that uses unqualified types.

Since the only thing needed here is ClientException for buildParseResponseWithException, consider narrowing the import:
-import 'package:http/http.dart';
+import 'package:http/http.dart' show ClientException;
This keeps the namespace clean while still enabling the new exception handling.

Please double‑check that no other symbols from http are used anywhere in the parts of this library before applying this change.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec71870 and 54a0f68.

📒 Files selected for processing (2)

packages/dart/lib/parse_server_sdk.dart (1 hunks)
packages/dart/lib/src/objects/response/parse_exception_response.dart (1 hunks)

🔇 Additional comments (1)

packages/dart/lib/src/objects/response/parse_exception_response.dart (1)

25-29: ClientException handling looks correct and aligns with existing patterns

The new ClientException branch cleanly maps http client errors into a ParseError, consistent with the generic fallback (no explicit error code, message taken from the exception) and separate from the richer DioException handling above.

Functionally this should resolve the issue where ClientException.toString() was previously exposed.

Please confirm:

That you have a test covering a thrown ClientException and asserting the resulting ParseResponse.error.message.

That no additional metadata (e.g., a specific error code) is needed for ClientException beyond what the generic fallback already provided.

handle http ClientException

65f624e

mbfakourii suggested changes Nov 28, 2024

View reviewed changes

mtrezza changed the title ~~handle http ClientException~~ fix: http client exception not handled properly resulting in incorrect error log Dec 4, 2024

parse-github-assistant bot changed the title ~~fix: http client exception not handled properly resulting in incorrect error log~~ fix: Http client exception not handled properly resulting in incorrect error log Dec 4, 2024

mtrezza changed the title ~~fix: Http client exception not handled properly resulting in incorrect error log~~ fix: Http client exception not handled properly resulting in incorrectly formatted error Dec 4, 2024

mbfakourii approved these changes Dec 9, 2024

View reviewed changes

Merge branch 'master' into handle-http-exception

54a0f68

coderabbitai bot reviewed Nov 15, 2025

View reviewed changes

coderabbitai bot approved these changes Nov 15, 2025

View reviewed changes

Uh oh!

fix: Http client exception not handled properly resulting in incorrectly formatted error #1021

Are you sure you want to change the base?

fix: Http client exception not handled properly resulting in incorrectly formatted error #1021

Conversation

2shrestha22 commented Nov 27, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request

Issue

Approach

Tasks

Summary by CodeRabbit

Uh oh!

parse-github-assistant bot commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks for opening this pull request!

Uh oh!

mbfakourii Nov 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

2shrestha22 Nov 28, 2024

Choose a reason for hiding this comment

Uh oh!

mbfakourii commented Nov 28, 2024

Uh oh!

mtrezza commented Nov 30, 2024

Uh oh!

codecov bot commented Nov 30, 2024

Codecov Report

Uh oh!

parse-github-assistant bot commented Dec 4, 2024

Uh oh!

mtrezza commented Dec 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

2shrestha22 commented Dec 4, 2024

Uh oh!

mtrezza commented Dec 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

2shrestha22 commented Nov 15, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

2shrestha22 commented Nov 27, 2024 •

edited by coderabbitai bot

Loading

parse-github-assistant bot commented Nov 27, 2024 •

edited

Loading

mbfakourii Nov 28, 2024 •

edited

Loading

mtrezza commented Dec 4, 2024 •

edited

Loading

mtrezza commented Dec 8, 2024 •

edited

Loading

coderabbitai bot commented Nov 15, 2025 •

edited

Loading